Remove in-place projection operations in PARAFAC2 #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #474 +/- ##
==========================================
- Coverage 88.50% 86.83% -1.67%
==========================================
Files 107 120 +13
Lines 6404 7461 +1057
==========================================
+ Hits 5668 6479 +811
- Misses 736 982 +246
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Thanks @aarmey, looks good to me. I really love changes that make the code more readable, which this does! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the in-place operations here were completely overwriting the existing values, so there wasn't a benefit of keeping this as in-place except maybe reducing allocations. For some backends, such as Jax, in-place operations are extremely slow, and so overall I expect this is both faster and more readable.