Honor Retry-After in from_http#6173
Open
aljazerzen wants to merge 1 commit into
Open
Conversation
raxyte
approved these changes
May 13, 2026
f1a0dbc to
2d4d8a4
Compare
4f4a7d6 to
58c8d8f
Compare
2d4d8a4 to
ceb6b83
Compare
Teach from_http to reuse the Retry-After parsing and backoff logic used by the shared HTTP client helpers. This preserves retry diagnostics while making 429 handling follow the server-provided delay and adds regression coverage for that path.
58c8d8f to
9f4a84d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 Problem
from_httpstill ignoresRetry-Afteron retryable HTTP responses.🛠️ Solution
Retry-Afterparsing and backoff helpers infrom_http.429withRetry-After.💬 Review
- Focus on the
- This PR is stacked on top of Add diagnostics for HTTP retries #6172.
- I did not run tests locally because this checkout has no configured build.
📎 Related: #6172from_httpretry path and the extracted HTTP retry-delay helpers.Resolves TNZ-590