Ignore illegal TESSDATA_PREFIX (not existing filesystem entry, issue #4277) #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egorpugin
reviewed
Jul 3, 2024
src/ccutil/ccutil.cpp
Outdated
| const char *tessdata_prefix = getenv("TESSDATA_PREFIX"); | ||
|
|
||
| // Ignore TESSDATA_PREFIX if there is no matching filesystem entry. | ||
| if (tessdata_prefix != nullptr && ! std::filesystem::exists(tessdata_prefix)) { |
There was a problem hiding this comment.
If this is not a space typo ! it is easier to use fs as
namespace fs = std::filesystem;
if (!fs::exists(...))
There was a problem hiding this comment.
It was a space typo which is fixed now, thanks for the hint.
…esseract-ocr#4277) Don't check for a directory, because a symbolic link is also allowed. Signed-off-by: Stefan Weil <sw@weilnetz.de>
egorpugin
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't check for a directory, because a symbolic link is also allowed.