Skip to content

Mar3hc/bug/stabilize android #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
test-fullautomation merged 9 commits into from
Jun 26, 2025
Merged

Mar3hc/bug/stabilize android #14

test-fullautomation merged 9 commits into from
Jun 26, 2025

Conversation

@trimai3001
Copy link
Collaborator

@trimai3001 trimai3001 commented Jun 24, 2025

No description provided.

@ngoan1608 ngoan1608 requested a review from Copilot June 24, 2025 08:55

This comment was marked as outdated.

Sign in to view

@test-fullautomation
Copy link
Owner

test-fullautomation commented Jun 24, 2025

Hi @trimai3001 , @ngoan1608 ,
did you check the Copilot findings. Some seem to be reasonable for me.
Thank you,
Thomas

@test-fullautomation test-fullautomation added enhancement New feature or request 0.14.1 labels Jun 24, 2025
@test-fullautomation test-fullautomation added this to the 0.14.1 milestone Jun 24, 2025
@ngoan1608 ngoan1608 requested a review from Copilot June 25, 2025 08:34

This comment was marked as outdated.

Sign in to view

test-fullautomation
test-fullautomation approved these changes Jun 25, 2025
View reviewed changes
Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tri,
looks good to me!
Thank you,
Thomas

@test-fullautomation
Copy link
Owner

test-fullautomation commented Jun 25, 2025

Hi @ngoan1608 ,
can you please give your review that I can merge.
Thank you,
Thomas

ngoan1608
ngoan1608 requested changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@ngoan1608 ngoan1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @trimai3001 ,

Please refer my comments for starting and stopping appium server on Windows.

Thank you,
Ngoan

@github-project-automation github-project-automation bot moved this from Open to In Progress in RobotFramework AIO Jun 26, 2025
@trimai3001 trimai3001 requested a review from ngoan1608 June 26, 2025 07:05
@ngoan1608 ngoan1608 requested a review from Copilot June 26, 2025 07:30

This comment was marked as outdated.

Sign in to view

@test-fullautomation
Copy link
Owner

test-fullautomation commented Jun 26, 2025

Hi @ngoan1608 ,
your confirmation is missing.
You need to confirm the requested changes as well as review to github that I can merge.
Thank you,
Thomas

@ngoan1608 ngoan1608 requested a review from Copilot June 26, 2025 08:22

This comment was marked as outdated.

Sign in to view

ngoan1608
ngoan1608 requested changes Jun 26, 2025
View reviewed changes
@trimai3001 trimai3001 requested a review from ngoan1608 June 26, 2025 08:25
@ngoan1608 ngoan1608 requested a review from Copilot June 26, 2025 08:28
Copilot AI reviewed Jun 26, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to stabilize Android test execution by updating various test lifecycle keywords and refactoring the way Android applications are launched and shut down. Key changes include:

  • Replacing "Close All Apps" with a more comprehensive "Shutdown All Test Services" sequence.
  • Refactoring multiple calls from "Open Application" to the new "Open Android Application" keyword with simplified parameter lists.
  • Adjusting shutdown procedures for appium and AVD to use consistent naming and improved handling.

ngoan1608
ngoan1608 approved these changes Jun 26, 2025
View reviewed changes
Copy link
Collaborator

@ngoan1608 ngoan1608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for now

@test-fullautomation test-fullautomation merged commit 682f019 into develop Jun 26, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in RobotFramework AIO Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ngoan1608 ngoan1608 ngoan1608 approved these changes

@test-fullautomation test-fullautomation test-fullautomation approved these changes

Assignees

No one assigned

Labels

0.14.1 enhancement New feature or request

Projects

RobotFramework AIO
Status: Done

Milestone

0.14.1

Development

Successfully merging this pull request may close these issues.

4 participants

@trimai3001 @test-fullautomation @ngoan1608