feat: map tx events to the txInfo #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwmerz
reviewed
Dec 15, 2023
mwmerz
left a comment
There was a problem hiding this comment.
Looks good. Build seems to be failing due to linting. Do we care if this auto-builds? should we add ts-ignores if we want to leave those lint issues in?
Contributor
Author
|
Thanks for the observation @mwmerz I think the issue is not actually linting but the tests, when I find some time I will try to fix all the failing tests. The problem is that these tests work agains the testnet and some of them will also need to be adjusted to the latest core upgrades |
… feat/tx/events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request maps three properties that weren't mapped before when quering the transaction info: