Skip to content

Conversation

@emidev98
Copy link
Contributor

Fixes the following issue #9

@emidev98 emidev98 linked an issue Jun 22, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #30 (9f06cd8) into main (fd09339) will increase coverage by 0.08%.
The diff coverage is 69.64%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   57.57%   57.65%   +0.08%     
==========================================
  Files         205      206       +1     
  Lines        8167     8223      +56     
  Branches      608      615       +7     
==========================================
+ Hits         4702     4741      +39     
- Misses       3429     3446      +17     
  Partials       36       36              
Impacted Files Coverage Δ
src/core/auth/Account.ts 31.70% <40.00%> (+1.15%) ⬆️
src/core/auth/ModuleAccount.ts 69.56% <69.56%> (ø)
src/client/lcd/api/AuthAPI.ts 100.00% <100.00%> (ø)
src/core/index.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@javiersuweijie javiersuweijie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emidev98 emidev98 merged commit e310260 into main Jun 23, 2023
@emidev98 emidev98 deleted the feat/module/acounts branch June 23, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement module_accounts API from Auth API.

4 participants