Skip to content

Add nchar to TextXError #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igordejanovic merged 4 commits into from
Nov 19, 2023
Merged

Add nchar to TextXError #421

igordejanovic merged 4 commits into from
Nov 19, 2023

Conversation

@davidchall
Copy link
Contributor

@davidchall davidchall commented Nov 18, 2023 •
edited
Loading

Fixes #420

Code review checklist

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly
  • Changelog(s) has/have been updated, as needed (see CHANGELOG.md, no need
    to update for typo fixes and such).

@davidchall davidchall marked this pull request as ready for review November 18, 2023 19:06
@igordejanovic
Copy link
Member

igordejanovic commented Nov 19, 2023

@davidchall Looks good. Thanks for the contribution.

@igordejanovic igordejanovic merged commit 5002628 into textX:master Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: TextXError gains length (or nchar) attribute

2 participants

@davidchall @igordejanovic