Add lab restart command and 1BRC validators by thearyanahmed · Pull Request #15 · thearyanahmed/luxctl

thearyanahmed · 2026-01-31T14:25:00Z

No description provided.

Implements two validators for performance challenges: - output_match: runs command, compares stdout to expected file - benchmark: validates output correctness and execution time Both validators support workspace detection from active lab state.

Adds factory methods and RuntimeValidator enum variants: - output_match:string(cmd),string(expected_file) - benchmark:string(cmd),string(expected_file),int(max_ms) Includes unit tests for DSL parsing.

Copilot

Pull request overview

This PR adds a lab restart command and introduces benchmark validators for performance-focused challenges like the 1 Billion Row Challenge (1BRC). The restart functionality allows users to reset their progress on a lab while maintaining their workspace, and the new validators enable correctness checking and performance benchmarking of command outputs.

Changes:

Added luxctl lab restart command with API integration
Implemented OutputMatchValidator and BenchmarkValidator for comparing command outputs against expected files
Added comprehensive E2E test suite covering authentication, lab lifecycle, and task operations

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/commands/lab.rs	Implements restart command handling with server synchronization
src/api/client.rs	Adds restart_lab API endpoint
src/api/types.rs	Defines RestartLabResponse and RestartLabData types
src/state.rs	Adds clear_progress method to reset task status
src/main.rs	Adds Restart action to CLI
src/validators/benchmark.rs	New module with output matching and benchmarking validators
src/validators/factory.rs	Registers new validators and factory functions
src/validators/mod.rs	Exports new benchmark validators
tests/e2e.rs	New E2E test suite for local API testing
src/lib.rs	Version bump to 0.7.0
Cargo.toml	Version bump to 0.7.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-31T14:33:50Z

+    let out = stdout(&output);
+    // should show user email or name
+    assert!(
+        out.contains("@") || out.len() > 0,


The condition out.len() > 0 is redundant and always true when combined with ||. Use !out.is_empty() as the second condition, or if any non-empty output is acceptable, simplify to just that check.

Suggested change

out.contains("@") || out.len() > 0,

!out.is_empty(),

Copilot · 2026-01-31T14:33:50Z

+fn get_workspace() -> PathBuf {
+    let config = match Config::load() {
+        Ok(c) => c,
+        Err(_) => return std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),
+    };
+    if !config.has_auth_token() {
+        return std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."));
+    }
+    let state = match LabState::load(config.expose_token()) {
+        Ok(s) => s,
+        Err(_) => return std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),
+    };
+    match state.get_active() {
+        Some(lab) => PathBuf::from(&lab.workspace),
+        None => std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),


The fallback std::env::current_dir().unwrap_or_else(|_| PathBuf::from(\".\")) is duplicated in lines 17, 20, 24, and 28. Extract this into a helper function or constant to improve maintainability.

Suggested change

fn get_workspace() -> PathBuf {

let config = match Config::load() {

Ok(c) => c,

Err(_) => return std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),

};

if !config.has_auth_token() {

return std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."));

}

let state = match LabState::load(config.expose_token()) {

Ok(s) => s,

Err(_) => return std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),

};

match state.get_active() {

Some(lab) => PathBuf::from(&lab.workspace),

None => std::env::current_dir().unwrap_or_else(|_| PathBuf::from(".")),

fn current_dir_or_dot() -> PathBuf {

std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."))

}

fn get_workspace() -> PathBuf {

let config = match Config::load() {

Ok(c) => c,

Err(_) => return current_dir_or_dot(),

};

if !config.has_auth_token() {

return current_dir_or_dot();

}

let state = match LabState::load(config.expose_token()) {

Ok(s) => s,

Err(_) => return current_dir_or_dot(),

};

match state.get_active() {

Some(lab) => PathBuf::from(&lab.workspace),

None => current_dir_or_dot(),

Copilot · 2026-01-31T14:33:50Z

+    let parts: Vec<&str> = cmd_str.split_whitespace().collect();
+    if parts.is_empty() {
+        return Err("empty command".to_string());
+    }
+
+    let program = parts[0];
+    let args = &parts[1..];


Using split_whitespace() for command parsing doesn't handle quoted arguments (e.g., paths with spaces). Consider using a proper shell-like parser or document this limitation, especially since this is used for benchmark commands that may reference file paths.

Copilot · 2026-01-31T14:33:50Z

+            let expected_lines: Vec<&str> = expected.lines().collect();
+
+            let mut diff_msg = String::new();
+            for (i, (a, e)) in actual_lines.iter().zip(expected_lines.iter()).enumerate() {


The diff generation logic in lines 120-130 and 187-196 is duplicated between OutputMatchValidator and BenchmarkValidator. Extract this into a shared helper function to reduce code duplication.

Replace verbose email-checking logic with simple empty check since any user info indicates success.

Extract current_dir_fallback() to reduce duplication in get_workspace(). Extract diff_preview() to consolidate duplicate diff generation logic. Add comment documenting split_whitespace limitation in run_command().

Copilot

Pull request overview

Copilot reviewed 12 out of 13 changed files in this pull request and generated 29 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-31T14:43:40Z

+const API_BASE_URL: &str = "http://0.0.0.0:8000";
+
+fn get_test_token() -> Option<String> {
+    // try dev_token file first (gitignored, local dev)


Corrected capitalization and improved comment clarity for 'try dev_token file first' to 'Try dev_token file first'.

Suggested change

// try dev_token file first (gitignored, local dev)

// Try dev_token file first (gitignored, local dev)

Copilot · 2026-01-31T14:43:41Z

+        }
+    }
+
+    // fallback to env var


Corrected capitalization for 'fallback to env var' to 'Fallback to env var'.

Suggested change

// fallback to env var

// Fallback to env var

Copilot · 2026-01-31T14:43:41Z

+}
+
+fn luxctl_with_token(args: &[&str], token: &str) -> Output {
+    // first authenticate, then run command


Corrected capitalization for 'first authenticate, then run command' to 'First authenticate, then run command'.

Suggested change

// first authenticate, then run command

// First authenticate, then run command

Copilot · 2026-01-31T14:43:41Z

+    String::from_utf8_lossy(&output.stderr).to_string()
+}
+
+// helper to check if local API is running


Corrected capitalization for 'helper to check if local API is running' to 'Helper to check if local API is running'.

Suggested change

// helper to check if local API is running

// Helper to check if local API is running

Copilot · 2026-01-31T14:43:41Z

+
+    let output = luxctl(&["auth", "--token", "invalid-token-12345"]);
+
+    // should fail gracefully


Corrected capitalization for 'should fail gracefully' to 'Should fail gracefully'.

Suggested change

// should fail gracefully

// Should fail gracefully

Copilot · 2026-01-31T14:43:45Z

+    String::new()
+}
+
+/// truncate string for display


Corrected capitalization for 'truncate string for display' to 'Truncate string for display'.

Suggested change

/// truncate string for display

/// Truncate string for display

Copilot · 2026-01-31T14:43:46Z

+        let actual = normalize(&stdout);
+        let expected = normalize(&expected);
+
+        // first check correctness


Corrected capitalization for 'first check correctness' to 'First check correctness'.

Suggested change

// first check correctness

// First check correctness

Copilot · 2026-01-31T14:43:46Z

+            });
+        }
+
+        // then check timing


Corrected capitalization for 'then check timing' to 'Then check timing'.

Suggested change

// then check timing

// Then check timing

Copilot · 2026-01-31T14:43:46Z

+
+    match client.restart_lab(&lab.slug).await {
+        Ok(response) => {
+            // refresh tasks from server


Corrected capitalization for 'refresh tasks from server' to 'Refresh tasks from server'.

Suggested change

// refresh tasks from server

// Refresh tasks from server

Copilot · 2026-01-31T14:43:46Z

+                    state.save(config.expose_token())?;
+                }
+                Err(_) => {
+                    // if refresh fails, just clear local progress


Corrected capitalization for 'if refresh fails, just clear local progress' to 'If refresh fails, just clear local progress'.

Suggested change

// if refresh fails, just clear local progress

// If refresh fails, just clear local progress

thearyanahmed added 11 commits January 31, 2026 13:58

Add restart lab response types

37316df

Add restart_lab API method

ae79973

Add clear_progress method for lab restart

9123cbb

Add lab restart command

e7e7e87

Bump version to 0.7.0

8b86fb2

Add E2E tests against local API

61d9004

Update Cargo.lock for version 0.7.0

7c0681a

Export benchmark validators in validators module

926ef13

Wire output_match and benchmark into validator DSL

3eaa412

Adds factory methods and RuntimeValidator enum variants: - output_match:string(cmd),string(expected_file) - benchmark:string(cmd),string(expected_file),int(max_ms) Includes unit tests for DSL parsing.

Fix VERSION constant to match Cargo.toml

17b47f1

thearyanahmed changed the title ~~wip~~ Add lab restart command and 1BRC validators Jan 31, 2026

thearyanahmed requested a review from Copilot January 31, 2026 14:32

Copilot AI reviewed Jan 31, 2026

View reviewed changes

thearyanahmed added 4 commits January 31, 2026 14:33

Add make e2e target for E2E tests

407618c

Remove block comment decorations

dd08c2e

Simplify redundant assertion in whoami E2E test

8f237c6

Replace verbose email-checking logic with simple empty check since any user info indicates success.

Refactor benchmark validator helpers

a830281

Extract current_dir_fallback() to reduce duplication in get_workspace(). Extract diff_preview() to consolidate duplicate diff generation logic. Add comment documenting split_whitespace limitation in run_command().

thearyanahmed requested a review from Copilot January 31, 2026 14:42

Copilot AI reviewed Jan 31, 2026

View reviewed changes

thearyanahmed merged commit d97517a into master Jan 31, 2026
1 check passed

thearyanahmed deleted the v0.9-reset-project-and-improved-validator branch March 24, 2026 21:57

	// try dev_token file first (gitignored, local dev)
	// Try dev_token file first (gitignored, local dev)

	// first authenticate, then run command
	// First authenticate, then run command

	// helper to check if local API is running
	// Helper to check if local API is running


		let output = luxctl(&["auth", "--token", "invalid-token-12345"]);

		// should fail gracefully

	/// truncate string for display
	/// Truncate string for display

	// if refresh fails, just clear local progress
	// If refresh fails, just clear local progress

Conversation

thearyanahmed commented Jan 31, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants