Refactor/use bollard for docker#28
Open
Shakib448 wants to merge 5 commits into
Open
Conversation
Migrate the Docker executor from shelling out to the CLI to the bollard crate, talking to the daemon directly. - pull, run, wait, logs, kill, and cleanup now use bollard - image build uses build_image with a gzip tar context (BuildKit enabled) - availability check queries the daemon via bollard - is_docker_available is now a method; dropped from re-export, test updated - remove unused Stdio and Command imports Updated for bollard 0.21: options use query_parameters builders, Config replaced by ContainerCreateBody, generics dropped from container methods.
Migrate the Docker executor from shelling out to the CLI to the bollard crate, talking to the daemon directly. - pull, run, wait, logs, kill, and cleanup now use bollard - image build uses build_image with a gzip tar context (BuildKit enabled) - availability check queries the daemon via bollard - is_docker_available is now a method; dropped from re-export, test updated - remove unused Stdio and Command imports Updated for bollard 0.21: options use query_parameters builders, Config replaced by ContainerCreateBody, generics dropped from container methods.
Migrate the Docker executor from shelling out to the CLI to the bollard crate, talking to the daemon directly. - pull, run, wait, logs, kill, and cleanup now use bollard - image build uses build_image with a gzip tar context (BuildKit enabled) - availability check queries the daemon via bollard - is_docker_available is now a method; dropped from re-export, test updated - remove unused Stdio and Command imports Updated for bollard 0.21: options use query_parameters builders, Config replaced by ContainerCreateBody, generics dropped from container methods.
Migrate the Docker executor from shelling out to the CLI to the bollard crate, talking to the daemon directly. - pull, run, wait, logs, kill, and cleanup now use bollard - image build uses build_image with a gzip tar context (BuildKit enabled) - availability check queries the daemon via bollard - is_docker_available is now a method; dropped from re-export, test updated - remove unused Stdio and Command imports Updated for bollard 0.21: options use query_parameters builders, Config replaced by ContainerCreateBody, generics dropped from container methods.
Migrate the Docker executor from shelling out to the CLI to the bollard crate, talking to the daemon directly. - pull, run, wait, logs, kill, and cleanup now use bollard - image build uses build_image with a gzip tar context (BuildKit enabled) - availability check queries the daemon via bollard - is_docker_available is now a method; dropped from re-export, test updated - remove unused Stdio and Command imports Updated for bollard 0.21: options use query_parameters builders, Config replaced by ContainerCreateBody, generics dropped from container methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace shell commands with Bollard API
Migrate the Docker executor from shelling out to the
dockerCLI toThe bollard crate, talking to the daemon directly.
Closes #6