Skip to content

Avoid using home_dir() due to Windows issues #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Avoid using home_dir() due to Windows issues #26

merged 2 commits into from
Jul 14, 2025

Conversation

@nabsul
Copy link
Collaborator

@nabsul nabsul commented Jul 14, 2025 •
edited by coderabbitai bot
Loading

Fixes #20

Tested in Windows. This should fix the issue.

Summary by CodeRabbit

Summary by CodeRabbit

  • Refactor
    • Updated the local path representation to use a tilde-based string ("~/.local") for improved compatibility.
  • Documentation
    • Revised the roadmap checklist to include a new item addressing home directory handling issues on Windows.

@coderabbitai
Copy link

coderabbitai bot commented Jul 14, 2025 •
edited
Loading

Walkthrough

The assignment of the LOCAL_PATH variable in the configuration file was updated from using a computed home directory path to a direct string literal containing a tilde, changing how the local path is represented within the code.

Changes

File(s) Change Summary
just/_config.just Changed LOCAL_PATH assignment from home_dir() / ".local" to "~/.local"
README.md Added roadmap item "Avoid using home_dir() due to Windows issues #26" and reordered checklist entries

Assessment against linked issues

Objective Addressed Explanation
Avoid use of home_dir() due to Windows path issues (#20, #26) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes detected.

Poem

A path once built with function's might,
Now wears a tilde, clear and light.
No more the call to home_dir's gate—
Just "~/.local" seals its fate.
A simple tweak, a rabbit's cheer,
For cleaner code, we all revere!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dd3a491 and 14c592b.

📒 Files selected for processing (1)
  • README.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • README.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nabsul nabsul marked this pull request as ready for review July 14, 2025 03:58
@gerhard
Add PR to README
14c592b 
Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
gerhard
gerhard approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@gerhard gerhard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all my dependencies installed in ~/.local and re-ran all commands that need them. Everything worked as expected 👍

@gerhard gerhard merged commit 35291ff into main Jul 14, 2025
4 checks passed
@gerhard gerhard deleted the nabsul/fix-local-dir branch July 14, 2025 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gerhard gerhard gerhard approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[WINDOWS] home_dir() does not work correctly

3 participants

@nabsul @gerhard