Skip to content

Fix feeds URL rewrite #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Fix feeds URL rewrite #31

merged 1 commit into from
Jul 24, 2025

Conversation

@gerhard
Copy link
Member

@gerhard gerhard commented Jul 24, 2025 •
edited by coderabbitai bot
Loading

/feeds/<UID> would be rewritten to /feeds/<UID>.xml, which was incorrect.

We want /<UID>.xml

Summary by CodeRabbit

  • Bug Fixes

    • Updated URL rewriting logic so that requests to /feeds/<UID> are now correctly rewritten to /<UID>.xml instead of /feeds/<UID>.xml.
    • Adjusted related test cases to match the new URL format.

  • Documentation

    • Updated the checklist to mark the production traffic routing as complete and added a note about the /feeds/<UID> rewrite fix.

@coderabbitai
Copy link

coderabbitai bot commented Jul 24, 2025 •
edited
Loading

Walkthrough

The changes update the URL rewriting logic for requests to the /feeds/* path in the Varnish VCL configuration and corresponding test cases. The rewritten URLs now remove the /feeds prefix, resulting in URLs like /feedname.xml. The README checklist is updated to reflect this completed fix.

Changes

File(s) Change Summary
README.md Updated checklist to mark 20% production traffic routing as complete and noted the /feeds/<UID> rewrite fix (PR #31).
test/vtc/feeds.vtc Updated test expectations and logic to match new /feeds/* URL rewrite behavior.
varnish/vcl/default.vcl Modified VCL regex and replacement to rewrite /feeds/* requests to /<feedname>.xml.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Varnish
    participant Backend

    Client->>Varnish: Request /feeds/<UID>
    Varnish->>Varnish: Rewrite URL to /<UID>.xml
    Varnish->>Backend: Forward /<UID>.xml with x-backend: feeds
    Backend-->>Varnish: Response
    Varnish-->>Client: Response
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A rabbit hops through lines of code,
Where /feeds/ paths now shed their load.
URLs rewritten, tests in sync,
Checklist checked off in a wink!
With every hop, the code grows neat—
A tidy patch, a bunny treat! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e2e0e9 and 4ea48be.

📒 Files selected for processing (3)
  • README.md (1 hunks)
  • test/vtc/feeds.vtc (2 hunks)
  • varnish/vcl/default.vcl (1 hunks)
🔇 Additional comments (5)
varnish/vcl/default.vcl (1)

200-203: LGTM! The URL rewriting logic correctly implements the intended behavior.

The regex substitution now properly rewrites /feeds/<UID> URLs to /<UID>.xml instead of /feeds/<UID>.xml, which aligns with the PR objectives. The pattern correctly captures the feed identifier while preserving query parameters.

test/vtc/feeds.vtc (3)

268-269: Test expectations correctly updated to match the new URL rewriting behavior.

The expected URL now correctly reflects the change from /feeds/0284CC5C777C51D158BBECCBBB56422A.xml to /0284CC5C777C51D158BBECCBBB56422A.xml, which aligns with the VCL modification.

273-274: Test expectations for query parameter scenario are correctly aligned.

This test case properly validates that the URL rewriting works correctly when query parameters are present, maintaining consistency with the VCL changes.

349-349: Test VCL mirrors the production configuration change.

The regex substitution in the test VCL correctly matches the production VCL change, ensuring test fidelity and proper validation of the URL rewriting logic.

README.md (1)

42-43: Documentation appropriately updated to reflect completed work.

The README correctly documents the completion of the feeds URL rewrite fix and properly references this PR (#31) for traceability. The checklist formatting and task completion status are accurate.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-feeds-rewrite

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gerhard
Fix feeds URL rewrite
4ea48be 
`/feeds/<UID>` would be rewritten to `/feeds/<UID>.xml`, which was
incorrect. We want `/<UID>.xml`.

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
@gerhard gerhard force-pushed the fix-feeds-rewrite branch from 424e271 to 4ea48be Compare July 24, 2025 21:02
@gerhard gerhard merged commit 218adfc into main Jul 24, 2025
4 checks passed
@gerhard gerhard deleted the fix-feeds-rewrite branch July 24, 2025 21:08
@gerhard gerhard added this to the 1.0 milestone Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gerhard