Skip to content

Handle varnish-json-response failing on startup #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Handle varnish-json-response failing on startup #33

merged 1 commit into from
Jul 30, 2025

Conversation

@gerhard
Copy link
Member

@gerhard gerhard commented Jul 30, 2025 •
edited by coderabbitai bot
Loading

If varnish is slower to start, varnish-json-response can fail instantly and trigger a vector failure which results in a zombie sh process that overmind does not seem to handle well.

Until this coproc shortcut gets replaced by individual processes handled by runit, and svlog handling logs & rotation, this fix will have to do for now.

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability and error handling for log processing, ensuring proper cleanup and clearer error messages if the logging service fails to start.

@gerhard gerhard added this to the 1.0 milestone Jul 30, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 30, 2025 •
edited
Loading

Walkthrough

The update revises the shell command used for the "logs" process in the Procfile within the app() method of the Pipely struct. The new command improves error handling, renames the coprocess, and ensures proper cleanup by trapping script exit and conditionally killing the coprocess if started.

Changes

Cohort / File(s) Change Summary
Procfile Command Update
dagger/main.go		 Modified the "logs" process command string: renamed coprocess, added error handling, and improved cleanup logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A bashful bunny tweaks the shell,
With traps and checks to make it well.
Logs now flow with tidy grace,
Coprocess cleaned—no messy trace!
A hop, a fix, a gentle cheer,
For Pipely’s logs are crystal clear.
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7935ddb and 77fcf29.

📒 Files selected for processing (1)
  • dagger/main.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • dagger/main.go
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch better-handle-varnish-slow-start

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gerhard gerhard mentioned this pull request Jul 30, 2025
Merged
coderabbitai[bot]
coderabbitai bot reviewed Jul 30, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3553723 and 7935ddb.

📒 Files selected for processing (1)
  • dagger/main.go (1 hunks)
🧰 Additional context used
🧠 Learnings (1)
dagger/main.go (1)

Learnt from: gerhard
PR: #18
File: dagger/main.go:292-304
Timestamp: 2025-07-03T08:51:11.320Z
Learning: When Go tools in dagger/main.go are pinned to specific commit hashes rather than release tags, this is intentional to access newer changes not yet included in releases. Avoid suggesting updates to release tags when commits are used, as the commits likely contain important unreleased features or fixes.

@gerhard
Better handle varnish-json-response failing on startup
77fcf29 
If varnish is slower to start, varnish-json-response can fail
instantly and trigger a vector failure which results in a zombie sh
process that overmind does not seem to handle well.

Until this coproc shortcut gets replaced by individual processes handled
by runit, and svlog handling logs & rotation, this fix will have to do
for now.

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
@gerhard gerhard force-pushed the better-handle-varnish-slow-start branch from 7935ddb to 77fcf29 Compare July 30, 2025 07:06
@gerhard gerhard merged commit 19c29d6 into main Jul 30, 2025
4 checks passed
@gerhard gerhard deleted the better-handle-varnish-slow-start branch July 30, 2025 07:09
@gerhard gerhard changed the title Better handle varnish-json-response failing on startup Handle varnish-json-response failing on startup Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gerhard