Skip to content

Increase backend timeout #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Increase backend timeout #36

merged 1 commit into from
Jul 31, 2025

Conversation

@gerhard
Copy link
Member

@gerhard gerhard commented Jul 31, 2025 •
edited by coderabbitai bot
Loading

We've been seeing 503 responses from Varnish when backends take more than 5s to respond. Some (very few) requests are large, and they genuinely need more than 5s, so increasing the timoeut to 10s, and seeing what happens seems a reasonable change.

FTR, we've had 69 x 503 responses in the last 24h. Let's see how this improves things...

Summary by CodeRabbit

  • Documentation

    • Updated release notes to reflect the completion of the v1.0-rc.6 release and added an entry about increased backend timeout.

  • Chores

    • Adjusted backend health check intervals and timeouts to allow for longer response times and less frequent health checks.

@gerhard
Increase backend timeout
c88e3b4 
We've been seeing 503 responses from Varnish when backends take more
than 5s to respond. Some (very few) requests are large, and they
genuinely need more than 5s, so increasing the timoeut to 10s, and
seeing what happens seems a reasonable change.

FTR, we've had 69 x 503 responses in the last 24h. Let's see how this
improves things...

Signed-off-by: Gerhard Lazu <gerhard@changelog.com>
@gerhard gerhard added this to the 1.0 milestone Jul 31, 2025
@coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2025 •
edited
Loading

Walkthrough

The README was updated to mark the "Tag & ship v1.0-rc.6" checklist item as complete and to add a new item about increasing backend timeout. In the Varnish configuration, backend health probe intervals and timeouts were increased, and backend director timeouts were doubled for the app, feeds, and assets directors.

Changes

Cohort / File(s) Change Summary
Release Documentation
README.md		 Updated release checklist to mark v1.0-rc.6 as shipped and added an item for increasing backend timeout.
Backend Timeout Configuration
varnish/vcl/default.vcl		 Increased health probe intervals and timeouts; doubled backend director timeouts for app, feeds, and assets.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Poem

A checklist ticked, a timeout grown,
The backend now less prone to moan.
Varnish waits with patient care,
For assets, feeds, and apps out there.
The roadmap’s neat, the config strong—
A bunny’s hop, and nothing’s wrong! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c78a6b and c88e3b4.

📒 Files selected for processing (2)
  • README.md (1 hunks)
  • varnish/vcl/default.vcl (2 hunks)
🔇 Additional comments (7)
README.md (2)

55-55: LGTM! Release status updated correctly.

The v1.0-rc.6 release is appropriately marked as complete.

57-57: LGTM! Backend timeout increase properly documented.

The new checklist item correctly documents the inclusion of backend timeout changes from PR #36 in the v1.0-rc.6 release.

varnish/vcl/default.vcl (5)

30-30: LGTM! Health probe interval appropriately increased.

Doubling the health check interval from 5s to 10s reduces backend load while still providing reasonable health monitoring frequency.

35-35: LGTM! Health probe timeout properly adjusted.

The probe timeout increase to 9s allows more time for backend health responses while staying below the 10s interval to prevent probe overlap.

60-62: LGTM! Backend timeouts consistently doubled for app director.

The timeout increases (first_byte_timeout: 10s, connect_timeout: 10s, between_bytes_timeout: 60s) provide adequate time for legitimate long-running requests, directly addressing the 503 error issue mentioned in the PR objectives.

69-71: LGTM! Backend timeouts consistently doubled for feeds director.

Timeout values match the app director configuration, ensuring consistent behavior across backend services.

78-80: LGTM! Backend timeouts consistently doubled for assets director.

All three backend directors now have identical timeout configurations, providing uniform handling of slow backend responses.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch increase-backend-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gerhard gerhard merged commit 712fbe1 into main Jul 31, 2025
4 checks passed
@gerhard gerhard deleted the increase-backend-timeout branch July 31, 2025 19:11
@coderabbitai coderabbitai bot mentioned this pull request Oct 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gerhard