bleat.startScan updates #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 9, 2016 21:14
dist/api.classic.js
Outdated
| adapter = definition; | ||
| }, | ||
| startScan: function(serviceUUIDs, foundFn, completeFn, errorFn) { | ||
| startScan: function(serviceUUIDs, foundFn, completeFn, errorFn, options) { |
There was a problem hiding this comment.
IMO an options object should be used to replace all args. Can you stick with arguments for this addition and just have an allowDuplicates argument?
e.g.:
startScan: function(serviceUUIDs, foundFn, completeFn, errorFn, allowDuplicates) There was a problem hiding this comment.
Thanks, great will update the pull request!
|
@thegecko What is the best method for splitting into two pull requests? |
|
@mikaelkindborg Nevermind :) |
|
@thegecko Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed callback function references in bleat.startScan, fixes #46
Added options object to bleat.startScan with option allowDuplicates, resolves #44