Skip to content

ReferenceError: val is not defined #39

Description

@dcposch

Currently, node-castv2 depends on an old version of protobufjs (3.x instead of the latest 5.x), which depends on an old version of bytebuffer, which has the following error:

.../bytebuffer/src/types/strings/vstring.js:67:63: 'val' is not defined.

I saw ReferenceError: val is not defined in our telemetry for WebTorrent Desktop.

That's weird, I thought-- reference errors are almost like syntax errors, they can be caught with a linter and should never happen at runtime.

So I ran standard on our whole node_modules folder, which crunched for a few minutes and then found the error above.

I think the easiest way to fix it is for node-castv2 to upgrade to the latest protobufjs.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions