-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Reword the recommendation to use Suspenders #760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stevepolitodesign
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to get more feedback on this, as I think the only controversial take is we're now suggesting we prefer Minitest over RSpec for new applications. There's an open discussion about this.
|
Thanks for you input, @stevepolitodesign I did want to get this going though, because I do not want to find myself or anyone else starting a new app for a client and running into all those issues by using suspenders, and getting a bunch or extra stuff we likely don't need in a fresh rails app. |
|
I'll also add that we have not used Suspenders for several new Team Rocker projects, so we're already not following the guidance. |
|
cc @samithoughtbot @slickepinne ☝️ |
samithoughtbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heyvaleria thank you for taking the time to clarify this! This will help others going forward!
Co-authored-by: Steve Polito <stevepolitodesign@users.noreply.github.com>
Co-authored-by: Steve Polito <stevepolitodesign@users.noreply.github.com>
fe24604 to
9daa37b
Compare
After this Slack conversation, we realised that Suspenders is not currently recommended after all.
https://thoughtbot.slack.com/archives/C05DN55CPL3/p1747661858395259