fix: HasManyThrough and HasOneThrough not working #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88328b7 to
f304838
Compare
Contributor
Author
|
@JustSteveKing @calebporzio Friendly poke: Is there a chance to have this reviewed and potentially merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR fixes issues with
HasOneThroughandHasManyThroughfor self-joins.In this case, the nested select would use the same table name/alias as the outer select.
This MR fixes this by replacing
$instance->getTable()with$query->getModel()->getTable(), which contain the correct inner table alias that laravel assigned to it.