Skip to content

[8.x] Further extract lint/format base #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
driftingly merged 2 commits into from
Nov 21, 2022
Merged

[8.x] Further extract lint/format base #300

driftingly merged 2 commits into from
Nov 21, 2022

Conversation

@driftingly
Copy link
Member

@driftingly driftingly commented Nov 7, 2022 •
edited
Loading

This PR further extracts properties and methods found in both BaseLinter and BaseFormatter to a new Base class.

Targetting 8.x because this would require changes to any userland formatters.

  • Add new Base
  • Update BaseLinter to extend Base
  • Update BaseFormatter to extend Base and add type hint
  • Update formatters to be compatible with new updated BaseFormatter
  • Remove unused concerns

@driftingly driftingly mentioned this pull request Nov 7, 2022
Merged
@driftingly driftingly changed the base branch from main to 8.x November 7, 2022 17:26
@driftingly driftingly changed the title Further extract lint/format base [8.x] Further extract lint/format base Nov 7, 2022
@driftingly driftingly merged commit 7e0be37 into 8.x Nov 21, 2022
@driftingly driftingly deleted the adc/update-bases branch November 21, 2022 19:58
@driftingly driftingly mentioned this pull request Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@driftingly