Drop older symfony/console and symfony/process
#334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakerkretzmar
approved these changes
Feb 18, 2023
Contributor
bakerkretzmar
left a comment
There was a problem hiding this comment.
LGTM 👍🏻 personally I don't think it requires a major version bump because it's not really a breaking change, users who require Symfony 4 or 5 just won't be able to upgrade yet.
Member
Author
|
Closing this, dropping PHP 8 in version 9; this update will be included there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops older versions of
consoleandprocessand bumps the min PHP version from8.0to8.0.2.Symfony Console and Process both have min PHP 8.0.2 requirements.
Since we dropped support for older versions of PHP we no longer need to support these older versions of Symfony components.
https://github.com/symfony/console/blob/6.0/composer.json
https://github.com/symfony/process/blob/6.0/composer.json
This may require a new major version.