Skip to content

Conversation

@driftingly
Copy link
Member

@driftingly driftingly commented May 11, 2023

This PR removes some excluded paths:

  • public
  • bootstrap
  • server.php
  • app/Http/Middleware/RedirectIfAuthenticated.php
  • app/Exceptions/Handler.php
  • app/Http/Controllers/Auth
  • app/Http/Kernel.php

There have been reports of sites being served from within a public directory being skipped. I have found blade in resources/views/public/*, for example, is also ignored.

Removing the other directories and files aligns us with tools like Pint, where all the files in the project are processed. This move causes the Auth facade to be replaced by the auth() helper in the auth controllers but will force consistency across the app.

Closes #338

@driftingly driftingly changed the base branch from main to 9.x May 22, 2023 16:05
@driftingly driftingly merged commit 4ba3918 into 9.x May 23, 2023
@driftingly driftingly deleted the adc/drop-excluded-paths branch May 23, 2023 17:13
@driftingly driftingly mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Public folder issue while linting

1 participant