ref #1731 -- apply suggested fix for comment order override #2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2015 +/- ##
============================================
- Coverage 95.01% 95.01% -0.01%
Complexity 1570 1570
============================================
Files 49 49
Lines 3709 3708 -1
============================================
- Hits 3524 3523 -1
Misses 185 185
Continue to review full report at Codecov.
|
Member
Author
|
@palmiak can I get your review? I think this is an artifact of some experimental stuff I was trying many years ago, that we're in the process of stripping out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1731
Issue
Manual ordering args were overridden by class's value
Solution
Make class's value the default, can now be overriden by user defined value
Impact
This will only cause an issue in the case where someone's failed attempts to override were unsuccessful — now they'll succeed
Testing
No new tests