[Distance metrics M1] support for L2 distance #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syvb
reviewed
Nov 12, 2024
cevian
requested changes
Nov 12, 2024
Collaborator
cevian
left a comment
There was a problem hiding this comment.
Overall looks good but some comments
cevian
requested changes
Nov 13, 2024
Collaborator
cevian
left a comment
There was a problem hiding this comment.
Everything looks good except for the update script which I still have concerns about.
pgrx sets CARGO_TARGET_DIR so we were previously sharing a target dir between multiple versions, which caused havoc. Now set explicitly.
cevian
reviewed
Nov 14, 2024
Co-authored-by: Matvey Arye <cevian@gmail.com> Signed-off-by: tjgreen42 <tj@timescale.com>
Co-authored-by: Matvey Arye <cevian@gmail.com> Signed-off-by: tjgreen42 <tj@timescale.com>
Signed-off-by: tjgreen42 <tj@timescale.com>
The cargo environment variable is needed for correct sql generation with versioned so's. Small fixes to migration scripts. Related to work adding l2.
syvb
approved these changes
Nov 15, 2024
cevian
approved these changes
Nov 15, 2024
Collaborator
cevian
left a comment
There was a problem hiding this comment.
may make sense to squash some commits
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for distance metrics besides
cosine, beginning withL2. The primitives for this metric were already present (earlier versions ofpgvectorscaleusedL2rather than cosine), so this PR just adds the operator class-related plumbing. As discussed in the design doc (see references) we followpgvectorsyntax.Testing
DistanceTypeparameter and addedL2versions of some of the callers. We could carry this out systemically and insist that all tests have variants covering all metrics, but this seems like overkill.EXPLAIN PLANthat the correct index is still chosen.test_upgradesucceeds (with generated sql schema, not included in this PR)References