This repository was archived by the owner on Apr 2, 2024. It is now read-only.
deploy/helm-chart: improve Service and annotation handling #1495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ded7d74 to
f15eea7
Compare
Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
f15eea7 to
d0c125e
Compare
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
The main motivation behind this change is to allow pod annotations to be customizable. As a side effect I refactored few other things that we wanted to do in the past:
openTelemetryandprometheustop level objects are now part ofserviceobject as they were affecting only Service object. Users also get a choice to enable or disable those ports to enable or disable access.prometheus.annotationsis removed as most of those annotations can be hardcodedprometheus.io/scrapeannotation has a value set fromserviceMonitor.enabled. This is because users should either use a serviceMonitor or prometheus annotation-based scrapingMerge requirements
Please take into account the following non-code changes that you may need to make with your PR: