Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Conversation

@paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Aug 8, 2022

Schema was generated using https://jsonschema.net/. More information
on schema generation can be found in https://www.arthurkoziel.com/validate-helm-chart-values-with-json-schemas/

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Note: If your PR involves benchmarks, you can run the Benchmarks workflow by adding action:benchmarks label. The PR must be opened from Promscale branch so that Github actions can leave a comment comparing results against master.

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@paulfantom paulfantom force-pushed the helm-schema branch 2 times, most recently from 1d1acb8 to f76fb26 Compare August 8, 2022 10:41
Schema was generated using https://jsonschema.net/. More information
on schema generation can be found in https://www.arthurkoziel.com/validate-helm-chart-values-with-json-schemas/

Signed-off-by: Paweł Krupa (paulfantom) <pawel@krupa.net.pl>
@paulfantom paulfantom marked this pull request as ready for review August 8, 2022 11:18
@paulfantom paulfantom requested review from a team and cevian as code owners August 8, 2022 11:18
Copy link
Contributor

@nhudson nhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paulfantom paulfantom merged commit 9c1653a into timescale:master Aug 8, 2022
@paulfantom paulfantom deleted the helm-schema branch August 8, 2022 18:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants