Skip to content
This repository was archived by the owner on Apr 2, 2024. It is now read-only.

Fix: 0 samples/sec in throughput by logging metric metadata throughput #1643

Merged
harkishen merged 1 commit into from
Sep 15, 2022
Merged

Fix: 0 samples/sec in throughput by logging metric metadata throughput #1643

harkishen merged 1 commit into from
Sep 15, 2022

Conversation

@harkishen
Copy link
Member

@harkishen harkishen commented Sep 14, 2022 •
edited
Loading

Fixes: #1642

Signed-off-by: Harkishen-Singh harkishensingh@hotmail.com

Description

This commit fixes 0 samples/sec logging in throughput. The reason behind this behaviour was metric-metadata not being printed, rather it was just updating the metrics-max-ts-send, which was causing the log.

This metrics-max-ts-send was updated even when we were writing metadata.

Now, the log for metric, metric-metadata and spans will be in single line, compared to the earlier separate lines.

level=info ts=2022-09-14T07:36:34.072Z caller=throughput.go:90 msg="ingestor throughput" samples/sec=80000 metrics-max-sent-ts="2022-09-14 07:36:13.178 +0000 UTC" metric-metadata/sec=249
level=info ts=2022-09-14T07:40:17.419Z caller=throughput.go:90 msg="ingestor throughput" samples/sec=64223 metrics-max-sent-ts="2022-09-14 07:39:41.002 +0000 UTC" spans/sec=200 spans-last-write-on="2022-09-14 07:40:16.459 +0000 UTC"

Update
Now we log like this.

level=info ts=2022-09-15T06:13:43.010Z caller=throughput.go:90 msg="ingestor throughput" spans/sec=200 spans-last-write-on=2022-09-15T06:13:42.14Z
level=info ts=2022-09-15T06:13:44.011Z caller=throughput.go:90 msg="ingestor throughput" samples/sec=1000 metrics-max-sent-ts=2022-09-15T06:13:42.583Z spans/sec=200 spans-last-write-on=2022-09-15T06:13:43.124Z

Merge requirements

Please take into account the following non-code changes that you may need to make with your PR:

  • CHANGELOG entry for user-facing changes
  • Updated the relevant documentation

@harkishen harkishen added this to the 0.15.0 milestone Sep 14, 2022
@harkishen harkishen self-assigned this Sep 14, 2022
@harkishen harkishen requested a review from a team as a code owner September 14, 2022 07:52
@harkishen harkishen force-pushed the throughput_for_metadata branch from e7bbb27 to 2fbcaa5 Compare September 14, 2022 07:54
alejandrodnm
alejandrodnm reviewed Sep 14, 2022
View reviewed changes
@harkishen harkishen force-pushed the throughput_for_metadata branch from 2fbcaa5 to ed427d5 Compare September 15, 2022 06:05
@harkishen
Fix: 0 samples/sec in throughput by logging metric metadata through…
353db62 
…put.

Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>

This commit fixes `0 samples/sec` logging in throughput. The reason
behind this behaviour was metric-metadata not being printed, rather
it was just updating the `metrics-max-ts-send`, which was causing the log.

The `metrics-max-ts-send` was updated even when we were writing metadata.

This commit also updates the logging of throughput, by making samples, spans
and metric-metadata log in the same line, than the earlier separate lines. This
allows better utilization of log lines.
@harkishen harkishen force-pushed the throughput_for_metadata branch from ed427d5 to 353db62 Compare September 15, 2022 06:14
@harkishen harkishen enabled auto-merge (rebase) September 15, 2022 06:17
@harkishen harkishen merged commit b0a862b into timescale:master Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@antekresic antekresic Awaiting requested review from antekresic

@arajkumar arajkumar Awaiting requested review from arajkumar

1 more reviewer

@alejandrodnm alejandrodnm alejandrodnm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harkishen harkishen

Labels

None yet

Projects

None yet

Milestone

0.15.0

Development

Successfully merging this pull request may close these issues.

Promscale logs 0 samples/sec

2 participants

@harkishen @alejandrodnm