This repository was archived by the owner on Apr 2, 2024. It is now read-only.
Reuse ingestion temp tables across batches #1679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
807ee93 to
a5e35d0
Compare
Contributor
Author
|
corresponding extension PR timescale/promscale_extension#526 |
2 tasks
alejandrodnm
approved these changes
Sep 30, 2022
JamesGuthrie
approved these changes
Sep 30, 2022
sumerman
approved these changes
Sep 30, 2022
Currently, the temp tables used for ingestion are named using a transient value. This PR substitutes the transient value for the metric_id. This change creates a temp table that is specific to the metric and database session which allows it to be reused. The temp table is currently created with ON COMMIT DROP, which requires that the temp table be recreated with each transaction. This incurs significant pg_catalog churn/bloat. A corresponding PR will be made in the extension to change this to ON COMMIT DELETE ROWS.
a5e35d0 to
9798e4a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the temp tables used for ingestion are named using a transient value. This PR substitutes the transient value for the metric_id. This change creates a temp table specific to the metric and database session, allowing it to be reused.
The temp table is currently created with ON COMMIT DROP, which requires that the temp table be recreated with each transaction. This incurs significant pg_catalog churn/bloat. A corresponding PR will be made in the extension to change this to ON COMMIT DELETE ROWS.
Merge requirements
Please take into account the following non-code changes that you may need to make with your PR: