remove callback key from user_callbacks_queue in remove_callback!
#591
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be cases where a callback key is removed from
user_callbacks_by_keybut it still remains inuser_callbacks_queue.The problem may be illustrated with the following MRE.
Say, with the following diff
and we run the following script:
where
watched.jlhas something like below:Now, boot up REPL and
include("entr.jl"), and then modifywatch.jlso that we alternately comment-in/out the lines of first/second state.
It will result in something like below on the current master:
, which will be fixed with this PR.
I think we can pack this into a test, but I feel it will be complicated and may be not so robust, so I've not done that yet.