Skip to content

NFC simplify runtests.jl (rework writes) #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timholy merged 1 commit into from
Jul 23, 2022
Merged

NFC simplify runtests.jl (rework writes) #696

timholy merged 1 commit into from
Jul 23, 2022

Conversation

@t-bltg
Copy link
Collaborator

@t-bltg t-bltg commented Jul 23, 2022 •
edited
Loading

This is a non functional change (NFC), rewriting runtests.jl by replacing:

open(path, "w") do io
  print(io, ...)
end

with:

write(path, ...)

Also make indentation consistent (+ one indentation level) on these writes.

I know NFCs are controversial, but IMO in this case, removing 400+ lines in a ~4000 lines file is worth considering for readability.

@timholy timholy merged commit 3bb68a2 into timholy:master Jul 23, 2022
@timholy
Copy link
Owner

timholy commented Jul 23, 2022

This is worth it, thanks!

@t-bltg t-bltg deleted the simplify branch July 23, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@t-bltg @timholy