use Base.Event instead of Base.Condition for revision_event
#965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd21d6c to
f37ad65
Compare
`Base.Condition` is not thread-safe, causing errors like "lock must be held" when `revise()` is called multithreaded. While `Threads.Condition` could be used, `Base.Event` provides a simpler approach to achieve thread-safety, so the code has been rewritten to use it instead.
f37ad65 to
135a08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.Conditionis not thread-safe, causing errors like "lock must be held" whenrevise()is called multithreaded. WhileThreads.Conditioncould be used,Base.Eventprovides a simpler approach to achieve thread-safety, so the code has been rewritten to use it instead.