feat(rufio): add HTTP proxy for BMC network #431
Conversation
81ec534 to
d4bbe6a
Compare
Signed-off-by: branko.mijuskovic <brankomijuskovic@gmail.com>
002e401 to
7e18486
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #431 +/- ##
==========================================
- Coverage 52.89% 52.72% -0.17%
==========================================
Files 107 107
Lines 7177 7202 +25
==========================================
+ Hits 3796 3797 +1
- Misses 3095 3116 +21
- Partials 286 289 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobweinstock
left a comment
There was a problem hiding this comment.
Hey @brankomijuskovic. Thanks for this PR!
|
Hey @jacobweinstock , thank you for the review. Hopefully it's a bit better now. Cheers |
ebfc8c1 to
02ea798
Compare
Signed-off-by: branko.mijuskovic <brankomijuskovic@gmail.com>
02ea798 to
152ab4b
Compare
| } | ||
| if proxyURL != "" { | ||
| httpClient := createHTTPClientWithProxy(proxyURL, b.InsecureTLS, timeout) | ||
| o = append(o, bmclib.WithRedfishHTTPClient(httpClient), bmclib.WithHTTPClient(httpClient)) |
There was a problem hiding this comment.
when bmclib.WithHTTPClient(httpClient) is provided, bmclib.WithRedfishHTTPClient(httpClient) shouldn't be needed. Unless you've seen different behavior in your testing?
| } | ||
|
|
||
| // Cookie jar with public suffix list, similar to bmclib's Build function | ||
| jar, _ := cookiejar.New(&cookiejar.Options{PublicSuffixList: publicsuffix.List}) |
There was a problem hiding this comment.
mind adding a comment there that cookiejar.New always returns a nil error, so it's safe to ignore it?
jacobweinstock
left a comment
There was a problem hiding this comment.
last couple requests. Thanks!
Description
Fixes: #430
How Has This Been Tested?
Tested on several Dell and SuperMicro servers. Tested both global and per resource proxy.
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I have: