Skip to content

add default template name in spec#51

Merged
hex108 merged 1 commit into
tkestack:masterfrom
qianjun1993:test
Sep 2, 2020
Merged

add default template name in spec#51
hex108 merged 1 commit into
tkestack:masterfrom
qianjun1993:test

Conversation

@qianjun1993
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread pkg/apis/tappcontroller/v1/types.go Outdated
// where "pod-specific-string" is managed by the TApp controller.
ServiceName string `json:"serviceName,omitempty"`

//DefaultTemplateName is the default template name for rolling or scale
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//DefaultTemplateName is the default template name for rolling or scale
//DefaultTemplateName is the default template name for scale

Comment thread pkg/apis/tappcontroller/v1/types.go Outdated
DefaultMaxUnavailable = 1
// DefaultRollingUpdateTemplateName is the default value for .Spec.UpdateStrategy.Template
DefaultRollingUpdateTemplateName = "default"
// DefaultRollingUpdateTemplateName = "default"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

34、35这两行都删了吧

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

均已修改

@hex108 hex108 merged commit a2e1dd8 into tkestack:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants