Add suport for specifying percentage of pods for RollingUpdate#36
Merged
Conversation
hex108
reviewed
Jun 18, 2020
| Template string `json:"template,omitempty"` | ||
| // MaxUnavailable is the max unavailable number when tapp is rolling update, default is 1. | ||
| MaxUnavailable *int32 `json:"maxUnavailable,omitempty"` | ||
| MaxUnavailable *intstr.IntOrString `json:"maxUnavailable,omitempty"` |
| if tapp.Spec.UpdateStrategy.MaxUnavailable != nil { | ||
| maxUnavailable = int(*tapp.Spec.UpdateStrategy.MaxUnavailable) | ||
| var err error | ||
| maxUnavailable, err = intstr.GetValueFromIntOrPercent(tapp.Spec.UpdateStrategy.MaxUnavailable, len(rollingUpdateIds), true) |
Contributor
There was a problem hiding this comment.
这里len(rollingUpdateIds) 改成desiredRunningPods.Len()会不会更合理
Contributor
Author
There was a problem hiding this comment.
百分比应该是指定要滚动更新的template的pod的，也就是rollingupdate的。换成desiredRunningpod会变成所有pod的
Contributor
Author
There was a problem hiding this comment.
结合现有的测试样例看了一下，其他template的更新会影响到滚动更新的template的数量，所以还是换成了desiredRunningpod。
| var err error | ||
| maxUnavailable, err = intstr.GetValueFromIntOrPercent(tapp.Spec.UpdateStrategy.MaxUnavailable, len(rollingUpdateIds), true) | ||
| if err != nil { | ||
| klog.Errorf("invalid value for MaxUnavailable: %v", err) |
b5535b9 to
74843d1
Compare
Contributor
|
@qianjun1993 没问题了，加一个测试用例？ |
Contributor
Author
|
追加了测试用例 |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add suport for specifying percentage of pods for RollingUpdate