Support reading rainfall from the kernel #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudson-ayers
previously approved these changes
Jan 17, 2025
Contributor
hudson-ayers
left a comment
There was a problem hiding this comment.
Generally looks good, but a couple comments on documentation
ppannuto
previously approved these changes
Jan 21, 2025
Member
ppannuto
left a comment
There was a problem hiding this comment.
lgtm pending hudson's comments
bb43a39
94835e0 to
bb43a39
Compare
Contributor
Author
|
Fixed! |
ppannuto
requested changes
Jan 29, 2025
Member
ppannuto
left a comment
There was a problem hiding this comment.
One last quick consistency thing I noticed. It doesn't really make sense for rainfall to be an int does it? I don't think it can be a negative value?
If I understand the driver correctly, it's a u32 in the kernel — probably should be the same in userspace?
Signed-off-by: Alistair Francis <alistair@alistair23.me>
bb43a39 to
2816e5a
Compare
Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
2816e5a to
aa7faae
Compare
Contributor
Author
Fixed! |
ppannuto
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.