Skip to content

Conversation

@lschuermann
Copy link
Member

@lschuermann lschuermann commented Feb 16, 2025

This adds an example application running an LwIP-based TCP/IP network
stack and HTTP server based on the EthernetTapDriver kernel capsule,
and the streaming process slice abstractions.

It includes commits from the following other PRs, which I will remove
once they have been merged:

@lschuermann lschuermann force-pushed the dev/lwip-ethernet-tap-example branch from e3e5d40 to 845a712 Compare February 16, 2025 20:43
@lschuermann
Copy link
Member Author

@bradjc @ppannuto I couldn't figure out how to exclude the lwip/lwip submodule from the formatting pass. I assume I'm missing something obvious, as it does work for all the other submodules...

Formatting ./lwip_ethernet_tap
../../lwip/Makefile:14: ../../lwip/lwip/src/Filelists.mk: No such file or directory
make: *** No rule to make target '../../lwip/lwip/src/Filelists.mk'.  Stop.
 ⤤ Failure formatting ./lwip_ethernet_tap
Rebuilding Verbose: ./lwip_ethernet_tap

@bradjc
Copy link
Contributor

bradjc commented Feb 17, 2025

@lschuermann

libtock-c/u8g2/Makefile

Lines 25 to 26 in 14e590a

# Avoid failing in CI due to warnings in the library.
override CPPFLAGS_$(LIBNAME) += -Wno-error

@bradjc
Copy link
Contributor

bradjc commented Feb 17, 2025

Need a https://github.com/tock/libtock-c/blob/master/lvgl/Makefile.setup and can you add a readme to the libtock/util folder to explain what goes in it? I assume we want it to be only be utilities related to abstractions provided by the tock kernel.

@lschuermann lschuermann force-pushed the dev/lwip-ethernet-tap-example branch 2 times, most recently from c2bcca3 to 911c62a Compare February 21, 2025 00:03
@lschuermann
Copy link
Member Author

lschuermann commented Feb 21, 2025

@lschuermann

libtock-c/u8g2/Makefile

Lines 25 to 26 in 14e590a

# Avoid failing in CI due to warnings in the library.
override CPPFLAGS_$(LIBNAME) += -Wno-error

@bradjc Still doesn't fix the formatting errors on the lwip submodule, unfortunately. Any hint on how to disable uncrustify for the submodule?

@lschuermann lschuermann force-pushed the dev/lwip-ethernet-tap-example branch from 911c62a to 55d5027 Compare February 21, 2025 00:05
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things and reminders. But this is just about ready to go once you have time to update it.

@ppannuto
Copy link
Member

ppannuto commented Mar 6, 2025

Okay, I believe all the make/build nonsense should be fixed. One thing I'm not 100% sure is okay is 3552552, but I don't really know what else to do here.

I think it's okay because newlib doesn't undef before trying to define BYTE_ORDER, so hopefully if there were ever a conflict due to include ordering, it'd show up as a redefinition warning?

@brghena brghena added the WG-Network In the purview of the Network working group. label Mar 24, 2025
@lschuermann lschuermann force-pushed the dev/lwip-ethernet-tap-example branch from 512bc44 to 114237c Compare May 5, 2025 15:08
@lschuermann lschuermann requested a review from brghena May 5, 2025 15:43
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more small nits

@lschuermann lschuermann force-pushed the dev/lwip-ethernet-tap-example branch from a95d521 to 8884c9f Compare May 5, 2025 16:56
@lschuermann lschuermann requested a review from brghena May 5, 2025 16:57
brghena
brghena previously approved these changes May 5, 2025
Copy link
Contributor

@brghena brghena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is a really great addition to userspace.

@brghena
Copy link
Contributor

brghena commented May 5, 2025

This is ready to go. So if anyone still has opinions, please comment soon.

@lschuermann
Copy link
Member Author

@brghena Fixed a small indentation mismatch in the README.

@lschuermann lschuermann requested a review from brghena May 6, 2025 02:44
@brghena brghena added this pull request to the merge queue May 8, 2025
Merged via the queue into master with commit 5508df7 May 8, 2025
4 checks passed
@brghena brghena deleted the dev/lwip-ethernet-tap-example branch May 8, 2025 19:13
@github-project-automation github-project-automation bot moved this from In review to Done in Tracker: Network Working Group May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WG-Network In the purview of the Network working group.

Projects

Development

Successfully merging this pull request may close these issues.

6 participants