-
Notifications
You must be signed in to change notification settings - Fork 103
Add LwIP Ethernet example using tap network driver #494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3e5d40 to
845a712
Compare
|
@bradjc @ppannuto I couldn't figure out how to exclude the |
|
Lines 25 to 26 in 14e590a
|
|
Need a https://github.com/tock/libtock-c/blob/master/lvgl/Makefile.setup and can you add a readme to the |
c2bcca3 to
911c62a
Compare
911c62a to
55d5027
Compare
brghena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things and reminders. But this is just about ready to go once you have time to update it.
|
Okay, I believe all the make/build nonsense should be fixed. One thing I'm not 100% sure is okay is 3552552, but I don't really know what else to do here. I think it's okay because newlib doesn't |
- Remove unneeded include in Makefile.app - Add necessary Makefile.setup for submodule checkout
512bc44 to
114237c
Compare
brghena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more small nits
a95d521 to
8884c9f
Compare
brghena
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This is a really great addition to userspace.
|
This is ready to go. So if anyone still has opinions, please comment soon. |
|
@brghena Fixed a small indentation mismatch in the README. |
This adds an example application running an LwIP-based TCP/IP network
stack and HTTP server based on the
EthernetTapDriverkernel capsule,and the streaming process slice abstractions.
It includes commits from the following other PRs, which I will remove
once they have been merged:
Configuration.mk: add TOCK_TARGETS for QEMU rv32 virt board #493: Configuration.mk: add TOCK_TARGETS for QEMU rv32 virt board