Many updates to comments in capsules/#1927
Merged
Merged
Conversation
2 tasks
Contributor
phil-levis
previously approved these changes
Jun 13, 2020
ppannuto
approved these changes
Jun 14, 2020
ppannuto
left a comment
Member
There was a problem hiding this comment.
This looks good to me.
@hudson-ayers I made capsules their own CI job. There's no reason to run the kernel tests if you're debugging a failing capsule test.
hudson-ayers
approved these changes
Jun 14, 2020
gendx
approved these changes
Jun 15, 2020
gendx
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Unclear to me what currently makes the CI jobs fail.
Member
|
bors r+ Looks an awful lot like infra failure ( 👎 ) on github actions; the next step never triggered and timed out... I just told all the CI to re-run. Assuming it passes, this should go through. |
Contributor
|
#1935 I think explains why the qemu CI is failing. |
Contributor
sirchnik
pushed a commit
to sirchnik/tock
that referenced
this pull request
May 12, 2026
1927: Many updates to comments in capsules/ r=ppannuto a=bradjc ### Pull Request Overview This pull request cherry picks the comment/test updates from tock#1512. These are useful even if we can't fully run the tests automatically. ### Testing Strategy n/a ### TODO or Help Wanted n/a ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Guillaume Endignoux <guillaumee@google.com> Co-authored-by: Hudson Ayers <hayers@stanford.edu> Co-authored-by: Pat Pannuto <pat.pannuto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request cherry picks the comment/test updates from #1512. These are useful even if we can't fully run the tests automatically.
Testing Strategy
n/a
TODO or Help Wanted
n/a
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.