OpenTitan: AES: Update the AES implementation#2629
Merged
Conversation
Set the AES mode before setting th key. This is required for OT AES to work. Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
dc141c2 to
c0476d6
Compare
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
c0476d6 to
061a220
Compare
bradjc
reviewed
Jun 23, 2021
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
061a220 to
9eb01b0
Compare
ppannuto
approved these changes
Jun 28, 2021
ppannuto
left a comment
Member
There was a problem hiding this comment.
It would be good to fix the HIL, but in the now, I guess the panics are better than incorrect behavior.
bradjc
approved these changes
Jun 28, 2021
Contributor
Author
|
This is ready to go |
Contributor
|
bors r+ |
Contributor
bors Bot
added a commit
that referenced
this pull request
Jul 6, 2021
2634: OpenTitan: Run tests r=bradjc a=alistair23 ### Pull Request Overview This PR builds on #2629 and adds tests for the OpenTitan board. ### Testing Strategy This PR! ### TODO or Help Wanted ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
sirchnik
pushed a commit
to sirchnik/tock
that referenced
this pull request
May 12, 2026
2629: OpenTitan: AES: Update the AES implementation r=bradjc a=alistair23 ### Pull Request Overview This updates the implemention to remove all infinite loops, use callbacks and update to the current OpenTitan bitstream addresses and registers. ### Testing Strategy Running the Tock AES tests. ### TODO or Help Wanted ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
sirchnik
pushed a commit
to sirchnik/tock
that referenced
this pull request
May 12, 2026
2634: OpenTitan: Run tests r=bradjc a=alistair23 ### Pull Request Overview This PR builds on tock#2629 and adds tests for the OpenTitan board. ### Testing Strategy This PR! ### TODO or Help Wanted ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <alistair.francis@wdc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This updates the implemention to remove all infinite loops, use callbacks and update to the current OpenTitan bitstream addresses and registers.
Testing Strategy
Running the Tock AES tests.
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.