fix log test#2746
Merged
Merged
Conversation
lschuermann
approved these changes
Aug 10, 2021
bradjc
approved these changes
Aug 10, 2021
Contributor
|
bors r+ |
Contributor
sirchnik
pushed a commit
to sirchnik/tock
that referenced
this pull request
May 12, 2026
2746: fix log test r=bradjc a=hudson-ayers ### Pull Request Overview This pull request fixes the log test to reflect the error actually returned when reading with a too-small buffer. This test failed on 1.6 release testing and was not fixed so this at least updates the test to a runnable state. An alternative fix would involve modifying the errors returned up/down the nonvolatile_storage stack, but that interface is highly unstable and `ErrorCode`s are not specified, so I am preferring the quick fix for now. ### Testing Strategy This pull request was tested by running the log test on imix ### TODO or Help Wanted N/A ### Documentation Updated - [x] no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Hudson Ayers <hayers@stanford.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes the log test to reflect the error actually returned when reading with a too-small buffer. This test failed on 1.6 release testing and was not fixed so this at least updates the test to a runnable state. An alternative fix would involve modifying the errors returned up/down the nonvolatile_storage stack, but that interface is highly unstable and
ErrorCodes are not specified, so I am preferring the quick fix for now.Testing Strategy
This pull request was tested by running the log test on imix
TODO or Help Wanted
N/A
Documentation Updated
Formatting
make prepush.