Fix temperature_stm driver to use 16 bits#3159
Merged
bors[bot] merged 1 commit intoAug 24, 2022
Merged
Conversation
Closed
bradjc
approved these changes
Aug 24, 2022
hudson-ayers
approved these changes
Aug 24, 2022
Contributor
|
bors r+ |
Contributor
sirchnik
pushed a commit
to sirchnik/tock
that referenced
this pull request
May 12, 2026
3159: Fix temperature_stm driver to use 16 bits r=hudson-ayers a=alexandruradovici ### Pull Request Overview This pull request fixes temperature driver for STM to use the correct encoding (16 bits instead of 12). The driver was assuming that the received value was using 12 bits, but the value was using 16. This error was most probably due to a fix in the STM chip to comply with the adc trait. ### Testing Strategy This pull request was tested using an STM32F412g Discovery Kit ### TODO or Help Wanted N/A ### Documentation Updated - [x] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [x] Ran `make prepush`. Co-authored-by: Alexandru RADOVICI <alexandru.radovici@wyliodrin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This pull request fixes temperature driver for STM to use the correct encoding (16 bits instead of 12). The driver was assuming that the received value was using 12 bits, but the value was using 16.
This error was most probably due to a fix in the STM chip to comply with the adc trait.
Testing Strategy
This pull request was tested using an STM32F412g Discovery Kit
TODO or Help Wanted
N/A
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.