-
Notifications
You must be signed in to change notification settings - Fork 71
Update tilem to v0.1.1 #764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@timower For some reason, the icon that gets included is broken. |
I use git LFS now, so |
|
Tested on my new rM2 and it works 😎 |
bkirwi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - left one suggestion anyways!
| url=https://github.com/timower/rM2-stuff/tree/master/apps/tilem | ||
| pkgver=0.0.7-3 | ||
| timestamp=2021-04-30T10:42Z | ||
| _tag=0.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be somewhat more deterministic to depend on a commit sha instead of a tag, in case the tag ever gets deleted & recreated. 0.1.1 corresponds to a383c22ff2ea7f4abe7aaaf936ed055a34f8523b in case you're interested in making that change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is true, we've been happy to use tags as a standard throughout toltec, As they are supposed to be deterministic and not moved if you are using git the way it's meant to be used. So far, I haven't noticed timower moving tags, so I'm not too concerned.
Using tags also makes it easier to update the package, as you just need to update the version number without looking, the hash, and the timestamp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure. It does feel inconsistent to check hashes for fetching a tarball over HTTPS, but not a git fetch... but if this is already how many packages work, this is not the time / place to shake that out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a fair point. I'd be happy to approve and merge a new PR to switch this over to a commit hash if you'd like. I had forgotten that this was doing a git checkout.
* Update tilem to v0.1.1 * Use latest build image * Switch to git lfs * Fix install path
### New Packages - `move-logs-to-opt` - 0.0.1-1 (#821) - Move log files to `/opt` to avoid filling up the root partition. - `oxide-extra` and `liboxide-dev` - 2.7-3 (#760) ### Updated Packages - `folly` - 0.0.1-4 (#823) - `koreader` - 2024.01-1 (#826) - `linux-stracciatella` - 5.4.70.4-1 (#808) - `oxide`, `oxide-utils`, `inject_evdev`, and `liboxide` - 2.7-3 (#760) - `puzzles` - 0.2.4-4 (#785) - `rm2-suspend-fix` - 0.0.0-3 (#821) - `genie` - 0.1.7-1 (#825) - `harmony` - 0.2.3-1 (#825) - `iago` - 0.1.2-1 (#825) - `remux` - 0.3.0-1 (#825) - `simple` - 0.2.1-1 (#825) - `tilem` - 0.1.1-1 (#764) - `toltec-base` - 1.3-1 (#806) - `yaft` - 0.1.1 (#763) - `zoneinfo-utils` - 2023c-1 (#702) - `rmfakecloud-proxy` - 0.0.3-5 (#757 #831) ### Packages removed - `erode`, `tarnish`, `decay`, and `corrupt` - Replaced by `oxide` - `fret`, and `anxiety` - Replaced by `oxide-extra` - `rot` - Replaced by `oxide-utils`
Release notes v0.1.0
Release notes v0.1.1