Skip to content

Conversation

@Eeems
Copy link
Member

@Eeems Eeems commented Dec 6, 2023

@Eeems Eeems added the packages Add or improve packages of the repository label Dec 6, 2023
@Eeems Eeems added this to the 2023-W50 Merge Window milestone Dec 6, 2023
@Eeems
Copy link
Member Author

Eeems commented Dec 6, 2023

@timower For some reason, the icon that gets included is broken.

2023-12-06T205544 318
tilem

@timower
Copy link

timower commented Dec 9, 2023

> file opt/etc/draft/icons/yaft.png
opt/etc/draft/icons/yaft.png: ASCII text
> cat opt/etc/draft/icons/yaft.png
version https://git-lfs.github.com/spec/v1
oid sha256:5e34a13870db6d6cffb1f3801678b93cfd91a93cfc64465c5dcc0b663601630e
size 17040

I use git LFS now, so git lfs pull might be required

@Eeems
Copy link
Member Author

Eeems commented Jan 13, 2024

Tested on my new rM2 and it works 😎

Copy link

@bkirwi bkirwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - left one suggestion anyways!

url=https://github.com/timower/rM2-stuff/tree/master/apps/tilem
pkgver=0.0.7-3
timestamp=2021-04-30T10:42Z
_tag=0.1.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be somewhat more deterministic to depend on a commit sha instead of a tag, in case the tag ever gets deleted & recreated. 0.1.1 corresponds to a383c22ff2ea7f4abe7aaaf936ed055a34f8523b in case you're interested in making that change!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is true, we've been happy to use tags as a standard throughout toltec, As they are supposed to be deterministic and not moved if you are using git the way it's meant to be used. So far, I haven't noticed timower moving tags, so I'm not too concerned.

Using tags also makes it easier to update the package, as you just need to update the version number without looking, the hash, and the timestamp.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure. It does feel inconsistent to check hashes for fetching a tarball over HTTPS, but not a git fetch... but if this is already how many packages work, this is not the time / place to shake that out!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a fair point. I'd be happy to approve and merge a new PR to switch this over to a commit hash if you'd like. I had forgotten that this was doing a git checkout.

@Eeems Eeems merged commit 6ca0720 into testing Jan 20, 2024
@Eeems Eeems deleted the Eeems-patch-17 branch January 20, 2024 20:15
Eeems added a commit that referenced this pull request Jan 28, 2024
* Update tilem to v0.1.1

* Use latest build image

* Switch to git lfs

* Fix install path
Eeems added a commit that referenced this pull request May 21, 2024
### New Packages
- `move-logs-to-opt` - 0.0.1-1 (#821)
  - Move log files to `/opt` to avoid filling up the root partition.
- `oxide-extra` and `liboxide-dev` - 2.7-3 (#760)

### Updated Packages
- `folly` - 0.0.1-4 (#823)
- `koreader` - 2024.01-1 (#826)
- `linux-stracciatella` - 5.4.70.4-1 (#808)
- `oxide`,  `oxide-utils`, `inject_evdev`, and `liboxide` - 2.7-3 (#760)
- `puzzles` - 0.2.4-4 (#785)
- `rm2-suspend-fix` - 0.0.0-3 (#821)
- `genie` - 0.1.7-1 (#825)
- `harmony` - 0.2.3-1 (#825)
- `iago` - 0.1.2-1 (#825)
- `remux` - 0.3.0-1 (#825)
- `simple` - 0.2.1-1 (#825)
- `tilem` - 0.1.1-1 (#764)
- `toltec-base` - 1.3-1 (#806)
- `yaft` - 0.1.1 (#763)
- `zoneinfo-utils` - 2023c-1 (#702)
- `rmfakecloud-proxy` - 0.0.3-5 (#757 #831)

### Packages removed
- `erode`, `tarnish`, `decay`, and `corrupt`
  - Replaced by `oxide`
- `fret`, and `anxiety`
  - Replaced by `oxide-extra`
- `rot`
  - Replaced by `oxide-utils`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Add or improve packages of the repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants