feat: impl handle_did_change_watched_files. #1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements file watching capabilities for workspace diagnostics by adding a handle_did_change_watched_files function and refactoring the workspace diagnostic system. The changes remove the complex throttling and mtime tracking mechanisms in favor of a simpler file-watcher-based approach.
- Implements file system watcher for TOML files with automatic diagnostic updates
- Removes workspace diagnostic throttling and mtime tracking infrastructure
- Switches from pull-based to push-based diagnostics only
- Simplifies workspace diagnostic handling by removing complex state management
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| editors/vscode/src/extension/index.ts | Removes automatic workspace diagnostic request on startup |
| editors/vscode/src/command/refresh-cache.ts | Reorders import statements |
| crates/tombi-lsp/src/workspace_diagnostics_throttle.rs | Removes throttling mechanism for workspace diagnostics |
| crates/tombi-lsp/src/workspace_diagnostic_state.rs | Removes workspace diagnostic state management |
| crates/tombi-lsp/src/mtime_tracker.rs | Removes file modification time tracking |
| crates/tombi-lsp/src/lib.rs | Removes references to deleted modules |
| crates/tombi-lsp/src/handler/workspace_diagnostic.rs | Simplifies workspace diagnostic handling to use file globbing |
| crates/tombi-lsp/src/handler/refresh_cache.rs | Removes workspace diagnostic state clearing |
| crates/tombi-lsp/src/handler/initialized.rs | Adds file system watcher registration |
| crates/tombi-lsp/src/handler/initialize.rs | Removes pull-based diagnostic capabilities |
| crates/tombi-lsp/src/handler/did_close.rs | Changes document removal to version clearing |
| crates/tombi-lsp/src/handler/did_change_watched_files.rs | Implements file change event handling with diagnostic updates |
| crates/tombi-lsp/src/handler/diagnostic.rs | Removes diagnostic type filtering |
| crates/tombi-lsp/src/handler.rs | Removes workspace diagnostic handler export |
| crates/tombi-lsp/src/diagnostic.rs | Simplifies workspace config structure |
| crates/tombi-lsp/src/config_manager.rs | Minor variable renaming |
| crates/tombi-lsp/src/backend.rs | Removes workspace diagnostic state and pull diagnostic support |
| crates/tombi-lsp/Cargo.toml | Adds serde_json dependency |
| crates/tombi-glob/src/lib.rs | Exports search_pattern_matched_paths function |
| crates/tombi-glob/src/file_search.rs | Makes search_pattern_matched_paths public |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.