feat: workspace_diagnostic.throttle_seconds is deprecated. #1106
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the throttle_seconds configuration option for workspace diagnostics. The change marks the option as deprecated with updated documentation explaining it's no longer needed.
Key Changes
- Updated documentation to mark
throttle_secondsas deprecated - Added
deprecatedattribute to the field and schema property - Simplified documentation from detailed throttling behavior explanation to deprecation notice
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| json.schemastore.org/tombi.json | Updates JSON schema to mark throttle-seconds as deprecated with new description |
| crates/tombi-config/src/server.rs | Adds deprecation attribute and updates field documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "throttle-seconds": { | ||
| "title": "Throttle interval in seconds", | ||
| "description": "Controls the throttling behavior of workspace diagnostics:\n- 0: Run only once (first execution), then always skip\n- >0: Skip if within the specified interval, allow if interval has passed\n\nDefault: Follows the editor's execution frequency (no additional throttling).", | ||
| "description": "**🚧 Deprecated 🚧**\\\nDon't need to use this option.", |
There was a problem hiding this comment.
[nitpick] Grammar improvement: 'Don't need to use this option' should be 'This option is no longer needed' for better clarity.
| "description": "**🚧 Deprecated 🚧**\\\nDon't need to use this option.", | |
| "description": "**🚧 Deprecated 🚧**\\\nThis option is no longer needed.", |
| /// | ||
| /// Default: Follows the editor's execution frequency (no additional throttling). | ||
| /// **🚧 Deprecated 🚧**\ | ||
| /// Don't need to use this option. |
There was a problem hiding this comment.
[nitpick] Grammar improvement: 'Don't need to use this option' should be 'This option is no longer needed' for better clarity.
| /// Don't need to use this option. | |
| /// This option is no longer needed. |
No description provided.