charts: add ignoreNamespaces for webhooks #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72ac766 to
0b7ad87
Compare
ee77e84 to
6b95f2f
Compare
molpako
reviewed
Nov 27, 2025
Contributor
molpako
left a comment
There was a problem hiding this comment.
@ushitora-anqou I left a few comments.
| - key: kubernetes.io/metadata.name | ||
| operator: NotIn | ||
| values: | ||
| {{- range $v := .}} |
Contributor
There was a problem hiding this comment.
nit: It might render correctly even without the space, but it's better to add it for consistency with the others.
Suggested change
| {{- range $v := .}} | |
| {{- range $v := . }} |
Member
Author
There was a problem hiding this comment.
This code is now unnecessary, so I've deleted it.
skoya76
previously approved these changes
Nov 27, 2025
…topolvm-system" by default Signed-off-by: Ryotaro Banno <ryotaro.banno@gmail.com>
6b95f2f to
e918b44
Compare
molpako
approved these changes
Nov 27, 2025
skoya76
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1115.