Nlcd dataset issue #3185
Open
Nlcd dataset issue #3185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we focus this PR on fixing downloads and open a separate PR to add 2024 data? The former can go into a 0.8.1 release soon but the latter should be saved for 0.9.0 since it changes a default. |
Contributor
Author
|
Oh nice catch, indeed, I haven't thought about that |
Draft
Member
|
I think this can be made simpler. See CDL as an example. |
Contributor
Author
|
Indeed the CDL implementation is simpler! Regarding the test coverage, should we add a test case to ensure an error is raised when the checksum is invalid? |
Member
|
I would just copy the CDL tests. |
f70b96b to
0ab66ec
Compare
… NLCD-dataset-issue
ad238ca to
dfeaa05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2877, this PR updates the link to download the NLCD dataset.
The dataset now provides a zip file containing the TIF file, so I used a similar method as in the Chesapeake dataset and updated the test file accordingly.
The dataset version on their website has been incremented. I haven't analyzed the changes further, but I tested the dataset by plotting it.
2024 data has also been added.