Fix mypy issues in docs #3120
Merged
Fix mypy issues in docs #3120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
approved these changes
Nov 21, 2025
Member
adamjstewart
left a comment
There was a problem hiding this comment.
Tested changes and the scripts still work. To my surprise, the ignore is not an issue even if types-requests isn't installed.
If you're interested, the other mypy error I get is with experiments, where I see a bunch of issues because earthengine-api is installed. I don't really want to require type stubs, especially for optional dependencies. I'm also thinking about moving these experiments out into separate repos.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this and listing
types-requestsas additional_dependencies in pre-commit config, we won't need to exclude docs/ folder from pre-commitRef: #3070