fix: make general optional again #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to b5a5287 in 24 seconds. Click for details.
- Reviewed
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/config/lib.rs:11
- Draft comment:
Good use of as_ref() with map_or to default to true if 'general' is missing. This change gracefully handles an optional general config. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. src/config/models.rs:7
- Draft comment:
Making the 'general' field an Option is appropriate to support configs without it. Ensure that default behavior is thoroughly documented. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_WTLm4ZWlYBHbyHka
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
b5a5287 to
4632ce7
Compare
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed 4632ce7 in 1 minute and 18 seconds. Click for details.
- Reviewed
31lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src/config/lib.rs:15
- Draft comment:
Consider using Option::map_or(true, |g| g.trace_content_enabled) instead of is_none_or for clarity, unless is_none_or is a deliberate custom extension. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. src/config/models.rs:7
- Draft comment:
Changing Config.general to Option is valid. Ensure other code accounts for its optionality; consider adding #[serde(default)] if a default is intended when omitted in the config. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment has two parts: 1) validating the change (not useful - we don't need validation comments) and 2) suggesting to check other code and consider #[serde(default)] (speculative and asking for verification). The struct already has Default derived and its field has a default, so the suggestion isn't even necessary. Maybe the comment is valuable because changing a field to Option could cause runtime errors if not handled properly in the rest of the codebase? While that's true, asking for verification violates our rules. The compiler will force handling of the Option type, and we trust the author to have handled this. Delete the comment. It's partly validation (which we don't want) and partly asking for verification (which we don't want). Any Option handling issues would be caught by the compiler.
Workflow ID: wflow_wPr5jRGQVFv3IPKU
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
doronkopit5
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Make
generalfield inConfigoptional and updateload_configto handle it, defaultingtrace_content_enabledto true if absent.generalfield inConfigstruct inmodels.rschanged toOption<General>.trace_content_enabledinGeneraldefaults to true ifgeneralisNone.load_configinlib.rsto handle optionalgeneralfield usingis_none_or.get_trace_content_enabledinlib.rsreturns true ifTRACE_CONTENT_ENABLEDis not set.This description was created by
for 4632ce7. You can customize this summary. It will automatically update as commits are pushed.