fix: handle empty clause in switch if statement #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CFG was wrong in presence of an empty last clause. Fixes #634.
mpl
reviewed
May 20, 2020
Comment on lines
+1513
to
+1516
| if len(c.child) == 0 { | ||
| c.tnext = n | ||
| c.fnext = n | ||
| } else { |
Collaborator
There was a problem hiding this comment.
this could be:
if len(c.child) == 0 {
c.tnext = n
c.fnext = n
continue
}
and then you don't need the else case, and you can unindent again the whole block.
mpl
approved these changes
May 20, 2020
Collaborator
mpl
left a comment
There was a problem hiding this comment.
superficial review.
I leave it to you to trigger the merge, in case you want to address my suggestion first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFG was wrong in presence of an empty last clause.
Fixes #634.