Skip to content

fix: do type check on assignment #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mvertes merged 2 commits into from
Jul 3, 2020
Merged

fix: do type check on assignment #738

mvertes merged 2 commits into from
Jul 3, 2020

Conversation

@nrwiersma
Copy link
Contributor

@nrwiersma nrwiersma commented Jul 2, 2020

Fixes #714

@nrwiersma nrwiersma added bug Something isn't working area/core labels Jul 2, 2020
@nrwiersma nrwiersma added this to the v0.8.x milestone Jul 2, 2020
@nrwiersma nrwiersma requested a review from mvertes July 2, 2020 13:13
@nrwiersma nrwiersma self-assigned this Jul 2, 2020
mvertes
mvertes approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mvertes
mvertes requested changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_test/struct51.go from #734 fails with this PR. Maybe extend itype.isRecursiveField which should apply here and does not.

@nrwiersma
Copy link
Contributor Author

nrwiersma commented Jul 3, 2020

We have types and rtypes so I think isRecursiveType might better.

@mvertes mvertes merged commit 4058fd8 into traefik:master Jul 3, 2020
@nrwiersma nrwiersma deleted the chan-assign branch July 3, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mvertes mvertes mvertes approved these changes

Assignees

@nrwiersma nrwiersma

Labels

area/core bug Something isn't working

Projects

None yet

Milestone

v0.13.x

Development

Successfully merging this pull request may close these issues.

Assigning a write chan to a read chan makes yaegi panic.

3 participants

@nrwiersma @mvertes @traefiker