Fix temporary archive init in Zippy::ZipArchive::Save#210
Closed
punk-floyd wants to merge 1 commit into
Closed
Conversation
On branch topic/fix-ZippyTempArchive Changes to be committed: modified: OpenXLSX/external/zippy/zippy.hpp + Fixed a bug in the generation of the pathname for a temporary archive used during a save operation. The implementation was peeling out the path by searching for the last '/', but Windows-based systems generally use '\'. The net result is that the temporary file is created in the current directory instead of the directory of the existing archive. If the current directory happens to be a 'protected' directory (such as the standard Program Files directories) then the file creation will fail. + In the scenario above, the failure to create the temporary archive was not caught, resulting in the code proceeding and eventually failing, but without any error information attached. The fix, included here, is to check the return value of mz_zip_writer_init_file and throw if it fails.
Collaborator
|
This pull request has been implemented manually in the May 2024 Update. If you could check this, but basically all backslashes in a (windows) path are now replaced by forward slashes, which work fine with C++ fopen etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On branch topic/fix-ZippyTempArchive
Changes to be committed:
modified: OpenXLSX/external/zippy/zippy.hpp