-
Notifications
You must be signed in to change notification settings - Fork 15
Add support for CookedIndex on object data resources #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CookedIndex on object data resources #36
Conversation
1a3e13d to
e9cd200
Compare
|
I took the liberty of finally running
If it's reasonable to do, yes. Binary compatibility isn't preserved everywhere, but it makes testing a lot easier in places where it is. Please add the test and I'll investigate why it's failing and see if it's something that can be fixed. |
Thanks, I've added two test cases now: a texture asset and a static mesh, both produced with UE 5.5.4. The |
|
More annoying than name map: imported packages should be sorted by package ID, which I believe I have fixed. I need to go back and test conversion on a 4.27 game to be confident in the change. Also if it's not too much trouble, it would be great to have a larger test asset with more names and more imported packages. Sorting two imports isn't very comprehensive. 😆 |
Nice! 👍
Hehe, fair enough. 😄 I've added a larger test asset now (which triggers a new test failure). Let me know if I can help further. |
8e8e040 to
103a4ad
Compare
This is to make
to-zenwork for assets produced with UE 5.5.I would have liked to add a
test_zen_asset_identity_conversiontest for this, but the test I tried to add failed because e.g. the name map had a slightly different order than the one produced by UE (one entry would be at a different index than in the editor's version). Does retoc aim to always produce the same ordering as the editor for the various maps?From manual testing it seems to work (tested with the third person example and with Borderlands 4).