Skip to content

Conversation

@ryukinix
Copy link
Member

@ryukinix ryukinix commented Mar 9, 2016

However, the dhcp doesn't compiling yet. Now we have some
trouble about deadlock goroutines.

@ryukinix
Copy link
Member Author

ryukinix commented Mar 9, 2016

Ow, right! One minute and I'll change that.

@ryukinix
Copy link
Member Author

ryukinix commented Mar 9, 2016

HMM, i made an test here. I'll try amend the commit, and as expected, the @rminnich attached at the earlier commit was be lost. I think we need more caution doing git commit --amend during revisions at PRs. Or I only do that at wrong way?

@ryukinix
Copy link
Member Author

ryukinix commented Mar 9, 2016

Wait, I will rebase that.

However, the dhcp doesn't compiling yet. Now we have some
trouble about deadlock goroutines.

Change-Id: Ia215217f0e5297647d9df44110555962bad62b06
Signed-off-by: Manoel Vilela <manoel_vilela@engineer.com>
@rminnich
Copy link
Member

rminnich commented Mar 9, 2016

LGTM

Approved with PullApprove

ryukinix added a commit that referenced this pull request Mar 9, 2016
ramfs.go: add netlink to keep at src, solve the dhcp import problem
@ryukinix ryukinix merged commit aa52adc into u-root:master Mar 9, 2016
hugelgupf pushed a commit to hugelgupf/u-root that referenced this pull request Jun 5, 2019
Redesigned to have a TPM interface and TPM1 and TPM2 implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants